chore(e2e): retire vite trusted-publisher override#8526
Open
jacekradko wants to merge 2 commits into
Open
Conversation
Bumps vite direct deps to ^7.3.3 across nine fixture templates and two
playground apps that were previously on vite 4/5/6/7.0, then drops the
corresponding entry from root pnpm.overrides and TRUSTED_OVERRIDES.
vite 7.1.3 is the first version published via OIDC trusted publisher.
@vitejs/plugin-react@^4 supports vite 4-7 so plugin versions don't need
to move. Fixture vite configs are minimal defineConfig({ plugins: [react()] })
and unaffected by 4→7 breaking changes.
🦋 Changeset detectedLatest commit: a126b02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@integration/templates/vue-vite/package.json`:
- Around line 16-18: The package.json currently pins "@vitejs/plugin-vue":
"^5.1.4" which is incompatible with "vite": "^7.3.3"; update the dependency to a
version that supports Vite 7 (e.g. change "@vitejs/plugin-vue" to "^6.0.0" or
later) so the template can build with Vite 7.3.3 and regenerate/install
lockfiles as needed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 29470f5d-3bb1-4c7f-ac13-5a8ff967c2f7
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (13)
.changeset/retire-vite-override.mdintegration/constants.tsintegration/templates/chrome-extension-vite/package.jsonintegration/templates/custom-flows-react-vite/package.jsonintegration/templates/express-vite/package.jsonintegration/templates/fastify-vite/package.jsonintegration/templates/hono-vite/package.jsonintegration/templates/react-router-library/package.jsonintegration/templates/react-vite/package.jsonintegration/templates/vue-vite/package.jsonpackage.jsonplayground/react-router/package.jsonplayground/vite-react-ts/package.json
💤 Files with no reviewable changes (1)
- integration/constants.ts
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
vite 7 declares peerOptional @types/node "^20.19.0 || >=22.12.0", which the react-vite template's ^18.19.33 pin fails under npm's strict resolution (pkglab uses npm internally). Bumps that template's @types/node to ^22.12.0. vue-vite was on @vitejs/plugin-vue ^5.1.4, which only supports vite 5/6. Bumps it to ^6.0.0 for vite 7 support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8522. Bumps
vitedirect dependencies to^7.3.3across nine integration test templates and two playground apps that were previously on vite 4/5/6/7.0, then drops thevite@<7.1.3entry from rootpnpm.overridesand fromTRUSTED_OVERRIDESinintegration/constants.ts.vite 7.1.3 is the first version published via OIDC trusted publisher.
@vitejs/plugin-react@^4supports vite 4 through 7 so plugin versions don't need to move alongside. Fixture vite configs are minimaldefineConfig({ plugins: [react()] })and aren't affected by 4→7 breaking changes. Validated locally with workspacepnpm installand an isolated fixture install + build smoke test ofreact-vite.